-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI builds should use 10.12 as min macOS version #121
Conversation
cc @daviewales |
This is improved.
However, actually running it gives a missing symbol:
I think this symbol was added in 10.14 or 10.15. I'm guessing that something's missed the min_macosx memo. I'll have another look through how it's built, but I'm wondering if it might be related to the dependencies installed with |
I think it's one of the libraries built in Need to see what flags does the /Configure command support when building OpenSSL and then send that in if it supports setting a min macOS version |
That was my next guess. I'll have a play. |
@daviewales I made a couple of changes in that script and we got new artefacts ready here - https://github.com/godotengine/godot-git-plugin/actions/runs/2819308657 Could you please test this artefact again? It should support macOS >=10.13. We couldn't do 10.12 because of some usages of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works!!! Confirmed on macOS 10.13.6.
Awesome! Thanks a ton for testing these builds! |
062bf32
to
c38a44d
Compare
Testing a fix for #119
(I don't have a mac 10.x system to test this on, so any help with that will be much appreciated!